Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for capturing Azure subscription information #4156

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Add telemetry for capturing Azure subscription information #4156

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f62d196
Capture subscription telemetry to replace Azure Account extension doi…
bwateratmsft Nov 7, 2023
0e2ce31
Refactoring for perf
bwateratmsft Nov 7, 2023
b4c367c
Suppress error display
bwateratmsft Nov 8, 2023
4ff18da
Explanatory comment
bwateratmsft Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/tree/registries/Azure/AzureRegistryDataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import type { Registry as AcrRegistry, RegistryListCredentialsResult } from '@azure/arm-containerregistry';
import { AzureSubscription, VSCodeAzureSubscriptionProvider } from '@microsoft/vscode-azext-azureauth';
import { IActionContext, callWithTelemetryAndErrorHandling } from '@microsoft/vscode-azext-utils';
import { RegistryV2DataProvider, V2Registry, V2RegistryItem, V2Repository, V2Tag, getContextValue, registryV2Request } from '@microsoft/vscode-docker-registries';
import { CommonRegistryItem, isRegistry, isRegistryRoot, isRepository, isTag } from '@microsoft/vscode-docker-registries/lib/clients/Common/models';
import * as vscode from 'vscode';
Expand Down Expand Up @@ -65,6 +66,7 @@ export class AzureRegistryDataProvider extends RegistryV2DataProvider implements
}

const subscriptions = await this.subscriptionProvider.getSubscriptions();
this.sendSubscriptionTelemetryIfNeeded();

return subscriptions.map(sub => {
return {
Expand Down Expand Up @@ -196,4 +198,33 @@ export class AzureRegistryDataProvider extends RegistryV2DataProvider implements
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
return this.authenticationProviders.get(registryString)!;
}

private hasSentSubscriptionTelemetry = false;
private sendSubscriptionTelemetryIfNeeded(): void {
if (this.hasSentSubscriptionTelemetry) {
return;
}
this.hasSentSubscriptionTelemetry = true;

// This event is relied upon by the DevDiv Analytics and Growth Team
void callWithTelemetryAndErrorHandling('updateSubscriptionsAndTenants', async (context: IActionContext) => {
context.telemetry.properties.isActivationEvent = 'true';
context.errorHandling.suppressDisplay = true;

const subscriptions = await this.subscriptionProvider.getSubscriptions(false);

const tenantSet = new Set<string>();
const subscriptionSet = new Set<string>();
subscriptions.forEach(sub => {
tenantSet.add(sub.tenantId);
subscriptionSet.add(sub.subscriptionId);
});

// Number of tenants and subscriptions really belong in Measurements but for backwards compatibility
// they will be put into Properties instead.
context.telemetry.properties.numtenants = tenantSet.size.toString();
context.telemetry.properties.numsubscriptions = subscriptionSet.size.toString();
context.telemetry.properties.subscriptions = JSON.stringify(Array.from(subscriptionSet));
});
}
}