Update targets to work correctly with 8.0.100-rc2 and up (#4201)

* Update targets to work correctly with 8.0.100-rc2 and up * Update resources/netCore/GetProjectProperties.targets Co-authored-by: Chet Husk <[email protected]> --------- Co-authored-by: Chet Husk <[email protected]>
microsoft · Jan 11, 2024 · b182624 · b182624
1 parent 5fa4733
commit b182624
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/resources/netCore/GetProjectProperties.targets b/resources/netCore/GetProjectProperties.targets
@@ -1,6 +1,12 @@
 <Project>
     <PropertyGroup>
-        <GetProjectPropertiesDependsOn Condition=" '$(SDKContainerSupportEnabled)' == 'true' ">$(GetProjectPropertiesDependsOn);ComputeContainerConfig;</GetProjectPropertiesDependsOn>
+        <!-- Handle the varying properties across the SDK version/PackageReference methods for enabling containerization.
+             For the PackageReference, SDKContainerSupportEnabled is present. For the SDK built-in version,  EnableSdkContainerSupport is the primary flag. 
+             Certain project types have it set automatically, while others require users to manually set the property.
+             So for compat, we need to make sure and be responsive to both flags to check if a project supports containerization.  -->
+        <EnableSdkContainerSupport Condition=" '$(EnableSdkContainerSupport)' == '' ">$(SDKContainerSupportEnabled)</EnableSdkContainerSupport>
+        <GetProjectPropertiesDependsOn Condition=" '$(EnableSdkContainerSupport)' == 'true' ">$(GetProjectPropertiesDependsOn);ComputeContainerConfig;</GetProjectPropertiesDependsOn>
+
     </PropertyGroup>
 
     <Target Name="GetProjectProperties" DependsOnTargets="$(GetProjectPropertiesDependsOn)">
@@ -14,7 +20,7 @@
 $(TargetFramework)$(TargetFrameworks.Split(';')[0])
 $(OutputPath)$(AssemblyName).dll
 $(ContainerWorkingDirectory)/$(AssemblyName).dll
-$(SDKContainerSupportEnabled)
+$(EnableSdkContainerSupport)
 $(InferImageName)"
             Overwrite="True" />
     </Target>