Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2517 improve tRPC error handling #2520

Conversation

tnaum-ms
Copy link
Collaborator

@tnaum-ms tnaum-ms commented Dec 10, 2024

  1. The key change in this pull request is the proper catching and wrapping of exceptions into a TRPCError object, which can then be correctly serialized, detected, and handled on the webview side.
  2. This improved error handling has been applied throughout the MongoCluster webviews.
  3. Additionally, a common function in the tRPC router has been added that displays an error message using VS Code. This new common function is now available to all webviews.

There is a follow-up work item lined up: #2521

Error Handling Improvements:

Telemetry Enhancements:

Minor Improvements:

@tnaum-ms tnaum-ms marked this pull request as ready for review December 11, 2024 09:50
@tnaum-ms tnaum-ms requested a review from a team as a code owner December 11, 2024 09:50
@tnaum-ms tnaum-ms linked an issue Dec 11, 2024 that may be closed by this pull request
@tnaum-ms tnaum-ms merged commit bab2fe6 into main Dec 12, 2024
2 checks passed
@tnaum-ms tnaum-ms deleted the dev/tnaum/#2517-Improve-tRPC-Error-Handling-for-WebView-Communication- branch December 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tRPC Error Handling for WebView Communication
2 participants