Fix issue with new getSubscriptions filtering

microsoft · Feb 3, 2025 · 2adec5c · 2adec5c
1 parent 241fee7
commit 2adec5c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/auth/CHANGELOG.md b/auth/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## 4.1.1 - 2025-02-03
+
+* Fix `VSCodeAzureSubscriptionProvider` implementation of `getSubscriptions` filtering returned subscriptions by `getSubscriptionFilters()` when the `filter` parameter is a `GetSubscriptionsFilter` object.
+
 ## 4.1.0 - 2025-01-31
 
 * Add filtering `getSubscriptions` by a specific account and/or tenant.

diff --git a/auth/package.json b/auth/package.json
@@ -1,7 +1,7 @@
 {
     "name": "@microsoft/vscode-azext-azureauth",
     "author": "Microsoft Corporation",
-    "version": "4.1.0",
+    "version": "4.1.1",
     "description": "Azure authentication helpers for Visual Studio Code",
     "tags": [
         "azure",

diff --git a/auth/src/VSCodeAzureSubscriptionProvider.ts b/auth/src/VSCodeAzureSubscriptionProvider.ts
@@ -151,7 +151,7 @@ export class VSCodeAzureSubscriptionProvider extends vscode.Disposable implement
             subscriptions.sort((a, b) => a.name.localeCompare(b.name));
 
         const subscriptionIds = await this.getSubscriptionFilters();
-        if (filter && !!subscriptionIds.length) { // If the list is empty it is treated as "no filter"
+        if (filter === true && !!subscriptionIds.length) { // If the list is empty it is treated as "no filter"
             return sortSubscriptions(
                 uniqueSubscriptions.filter(sub => subscriptionIds.includes(sub.subscriptionId))
             );