[gz-ports, sdformat] Update gz-ports #43265

talregev · 2025-01-14T18:25:02Z

Changes comply with the maintainer guide.
SHA512s are updated for each updated download.
The "supports" clause reflects platforms that may be fixed by this new version.
Any fixed CI baseline entries are removed from that file.
Any patches that are no longer applied are deleted from the port's directory.
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
Only one version is added to each modified port's versions file.

Signed-off-by: Tal Regev <[email protected]>

talregev · 2025-01-20T03:28:39Z

@WangWeiLin-MV @LilyWangLL
The PR is ready for review

WangWeiLin-MV

Take gz-cmake* as an example.

gz-cmake
- 4 repositories, https://repology.org/projects/?search=gz-cmake
ignition-cmake0
- 1 repository, https://repology.org/project/ignition-cmake0/versions only exist in vcpkg
ignition-cmake-2
- 1 repository, https://repology.org/project/ignition-cmake-2/versions only exist in AUR
ignition-cmake2
- 6 repositories, https://repology.org/project/ignition-cmake2/versions
- Ubuntu 20.04 for 2.1.1, Raspbian Stable for 2.1.1, Vcpkg
ignition-cmake
- Most repositories, https://repology.org/project/ignition-cmake/versions
- Ubuntu 20.04 for 0.6.1, Ubuntu 22.04 for 2.10.0, Raspbian Stable for 2.11.0

There are 4 ports: 3 ports named ignition-cmake0, ignition-cmake2, gz-cmake3 in vcpkg/ports, and 1 port gz-cmake4 in this PR. The home page of all these ports linked to https://ignitionrobotics.org/libs/cmake (Will redirect to https://gazebosim.org/libs/cmake/)

Although the exported package names do not conflict, ignition-cmake0, ignition-cmake2, gz-cmake3, should we only maintain the latest version and rename it to the name without version?

@vicroms Waiting for further review.

talregev · 2025-01-22T11:36:23Z

@WangWeiLin-MV Can you put requires:vcpkg-team-review label that the team will review it?

WangWeiLin-MV · 2025-01-23T02:13:27Z

Waiting for further review.
@vicroms @BillyONeal

BillyONeal · 2025-02-04T05:58:32Z

ports/gz-cmake4/dependencies.patch

@@ -0,0 +1,200 @@
+diff --git a/cmake/FindFreeImage.cmake b/cmake/FindFreeImage.cmake
+index 8a5836e..7f926cc 100644
+--- a/cmake/FindFreeImage.cmake


Review note: This file is substantially identical to the gz-cmake3 one with the tinyxml block moved around.

No change requested.

dg0yt

This comments were never sent... Maybe I never finished the review.

dg0yt · 2025-01-27T08:25:19Z

ports/gz-cmake4/dependencies.patch

+if(FreeImage_FOUND)
+  # done  


Never skip.

dg0yt · 2025-01-27T08:26:02Z

ports/gz-cmake4/dependencies.patch

+           "${OGRE2LIBNAME}${component}.${OGRE2_VERSION}"
+           "${OGRE2LIBNAME}${component}"
+          "${OGRE2LIBNAME}${component}Static"
+          "${OGRE2LIBNAME}${component}Static_d"          


NAMES_PER_DIR nearby?

dg0yt · 2025-01-27T08:27:25Z

ports/gz-cmake4/dependencies.patch

+-      list(APPEND OGRE2_PATHS "${_rootPath}/lib/${OGRE2_SEARCH_VER}/manual-link/")
+-      list(APPEND OGRE2_INC_PATHS "${_rootPath}/include/${OGRE2_SEARCH_VER}")
+      get_filename_component(debug_dir "${_rootPath}" NAME)
+      if(debug_dir MATCHES "debug" AND CMAKE_BUILD_TYPE MATCHES Debug OR NOT debug_dir MATCHES "debug" AND CMAKE_BUILD_TYPE MATCHES Release)


What is the intention of this condition?

dg0yt · 2025-01-27T08:30:14Z

ports/gz-cmake4/usage

@@ -0,0 +1,3 @@
+The package gz-cmake4 provides CMake integration:
+
+    find_package(gz-cmake4 CONFIG REQUIRED)


This not showing any actual use.

BillyONeal · 2025-02-04T06:12:11Z

Take gz-cmake* as an example.

I agree that this is ... unusual but we have accepted it in the past, as the gz-Xxx and ignition-Xxx appear to intentionally support simultaneous versions. I think we should continue letting contributors follow a pattern they've been following for years unless we have strong reason to change how something works. That said,

@talregev What do you think about dropping the version number suffixes and maintaining only one set we know work together? Or do you know of customers who specifically need many simultaneous versions necessitating so many duplicates?

BillyONeal · 2025-02-04T06:19:10Z

arm64-osx looks like a transient network issue

talregev · 2025-02-04T07:18:05Z

What do you think about dropping the version number suffixes and maintaining only one set we know work together?

I am in favor to dropping the version number suffixes, and only in needed cases we can add the one alongside with version number suffixes.

But I cannot do it alone. We need to fix gz-common6 first, currently I didn't succeeded to compile it on osx and linux.
and it very basic in the gz ports, and it will limited heavily other ports.
https://github.com/microsoft/vcpkg/pull/43265/files#diff-a1a3210f49402878917bb13f06dfe89def10114b731dfb51d3e16c1a1f563995R7

Also we should delist port gazebo. this is a gazebo classic, that ended it life:
https://github.com/gazebosim/gazebo-classic/

And we can try in other PR to add the current gazebo as gz-sim port:
https://github.com/gazebosim/gz-sim

talregev · 2025-02-04T08:01:57Z

@dg0yt Thank you for your comments.
All your comments, the code was taken from gz-cmake3 code. It a code that I copy and modify for gz-cmake4.

dg0yt · 2025-02-04T08:04:29Z

All your comments, the code was taken from gz-cmake3 code. It a code that I copy and modify for gz-cmake4.

Yeah, bad examples proliferate.

talregev · 2025-02-04T08:05:47Z

All your comments, the code was taken from gz-cmake3 code. It a code that I copy and modify for gz-cmake4.

Yeah, bad examples proliferate.

Sorry, I am not sure how to fix it. Can you suggest fixes, and I will apply them?

dg0yt · 2025-02-04T08:25:56Z

Can you suggest fixes, and I will apply them?

None of the three review comment needs extra suggestion at the moment.

BillyONeal · 2025-02-05T04:45:15Z

The conflict between gz-gui7 and gz-gui9 looks like a real conflict.

I am in favor to dropping the version number suffixes, and only in needed cases we can add the one alongside with version number suffixes.

But I cannot do it alone. We need to fix gz-common6 first, currently I didn't succeeded to compile it on osx and linux. and it very basic in the gz ports, and it will limited heavily other ports. https://github.com/microsoft/vcpkg/pull/43265/files#diff-a1a3210f49402878917bb13f06dfe89def10114b731dfb51d3e16c1a1f563995R7

Also we should delist port gazebo. this is a gazebo classic, that ended it life: https://github.com/gazebosim/gazebo-classic/

And we can try in other PR to add the current gazebo as gz-sim port: https://github.com/gazebosim/gz-sim

Tagging other folks who have touched the ignitionrobotics stuff in the past:

@traversaro
@ahoarau
@Sibras
@RobbertProost

What are your thoughts about this situation?

traversaro · 2025-02-05T09:30:26Z

What are your thoughts about this situation?

First of all, I am a happy user of vcpkg for other projects, so I am quite sorry for creating the problem in the first place and then stopping using vcpkg for ignition/gazebo packages. If you are interested in a bit of history, the initial ports (using major version in the name) of ignition/gazebo packages were added in #7781 . The rationale for doing that was part of the original description of the PR.

The possibility of installing side-by-side multiple major version of ignition/gazebo packages in the same system/project/environment (depending on weather you are using a system/project/environment package manager) was quite convenient when both Gazebo Classic and gz-sim (i.e "Modern Gazebo") were supported and used different major versions of their dependencies. However, now that Gazebo Classic reached its EOL (the repo was archived: https://github.com/gazebosim/gazebo-classic) it is not so useful anymore, and even upstream is considering dropping this possibility: gazebo-tooling/release-tools#1244 .

For these reasons, my answer to:

What do you think about dropping the version number suffixes and maintaining only one set we know work together? Or do you know of customers who specifically need many simultaneous versions necessitating so many duplicates?

I think it make perfect sense to drop all the version number suffixes and just package the latest major version of each gz library.

traversaro · 2025-02-05T09:35:41Z

ports/gz-cmake4/usage

@@ -0,0 +1,3 @@
+The package gz-cmake4 provides CMake integration:
+
+    find_package(gz-cmake4 CONFIG REQUIRED)


Taking as example

vcpkg/ports/ecm/usage

Line 4 in 3de032f

list(INSERT CMAKE_MODULE_PATH 0 ${ECM_MODULE_PATH})

, I guess an example of actual usage (inspired from https://github.com/gazebosim/gz-cmake/blob/ceee29190f18847687d1a383c6f6b1219ce95744/examples/gz_conf/CMakeLists.txt) is:

Suggested change

find_package(gz-cmake4 CONFIG REQUIRED)

find_package(gz-cmake4 CONFIG REQUIRED)

gz_configure_project()

gz_configure_build(QUIT_IF_BUILD_ERRORS)

talregev added 16 commits January 14, 2025 20:20

Add gz-cmake4

dbf1560

Signed-off-by: Tal Regev <[email protected]>

Add gz-utils3

bfd953d

Signed-off-by: Tal Regev <[email protected]>

Add gz-math8

f058513

Signed-off-by: Tal Regev <[email protected]>

Add gz-common6

e88c622

Signed-off-by: Tal Regev <[email protected]>

Add gz-msgs11

9e55215

Signed-off-by: Tal Regev <[email protected]>

Add gz-fuel_tools10

72e7ce4

Signed-off-by: Tal Regev <[email protected]>

Add gz-transport14

d1438f2

Signed-off-by: Tal Regev <[email protected]>

Add gz-plugin3

1909825

Signed-off-by: Tal Regev <[email protected]>

Update gz-tools2

f551793

Signed-off-by: Tal Regev <[email protected]>

Add sdformat15

5ad4b9e

Signed-off-by: Tal Regev <[email protected]>

Add gz-physics8

da54e2d

Signed-off-by: Tal Regev <[email protected]>

Add gz-rendering9

060d3cd

Signed-off-by: Tal Regev <[email protected]>

Add gz-sensors9

614ee26

Signed-off-by: Tal Regev <[email protected]>

Add gz-gui9

c346a05

Signed-off-by: Tal Regev <[email protected]>

Fix gz-msgs11

3a26a2c

Signed-off-by: Tal Regev <[email protected]>

register all ports

8871b1d

Signed-off-by: Tal Regev <[email protected]>

talregev force-pushed the TalR/gz_ports branch 4 times, most recently from d3686fa to e4262db Compare January 14, 2025 23:02

LilyWangLL assigned WangWeiLin-MV Jan 15, 2025

talregev force-pushed the TalR/gz_ports branch 2 times, most recently from 6c68c31 to 2b2dc74 Compare January 17, 2025 07:48

WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Jan 17, 2025

talregev force-pushed the TalR/gz_ports branch from 2b2dc74 to 34c92b7 Compare January 17, 2025 08:48

fix bugs for ports

28930c1

Signed-off-by: Tal Regev <[email protected]>

talregev force-pushed the TalR/gz_ports branch from 34c92b7 to 28930c1 Compare January 17, 2025 08:49

talregev marked this pull request as ready for review January 17, 2025 11:00

WangWeiLin-MV requested changes Jan 20, 2025

View reviewed changes

talregev requested a review from WangWeiLin-MV January 22, 2025 11:35

vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Feb 1, 2025

BillyONeal reviewed Feb 4, 2025

View reviewed changes

dg0yt reviewed Feb 4, 2025

View reviewed changes

LF-ize

2fdb18f

BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Feb 4, 2025

BillyONeal marked this pull request as draft February 5, 2025 04:40

traversaro reviewed Feb 5, 2025

View reviewed changes

This was referenced Feb 15, 2025

[ignition-*, dartsim] delist ignition-* ports, fix dartsim #43865

Merged

[gz-physics6] Fix the build #43926

Closed

[gz-*] Rename gz-* ports #43945

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gz-ports, sdformat] Update gz-ports #43265

[gz-ports, sdformat] Update gz-ports #43265

talregev commented Jan 14, 2025 •

edited by WangWeiLin-MV

Loading

talregev commented Jan 20, 2025

WangWeiLin-MV left a comment

talregev commented Jan 22, 2025 •

edited

Loading

WangWeiLin-MV commented Jan 23, 2025

BillyONeal Feb 4, 2025

dg0yt left a comment

dg0yt Jan 27, 2025

dg0yt Jan 27, 2025

dg0yt Jan 27, 2025

dg0yt Jan 27, 2025

BillyONeal commented Feb 4, 2025 •

edited

Loading

BillyONeal commented Feb 4, 2025

talregev commented Feb 4, 2025 •

edited

Loading

talregev commented Feb 4, 2025

dg0yt commented Feb 4, 2025

talregev commented Feb 4, 2025

dg0yt commented Feb 4, 2025

BillyONeal commented Feb 5, 2025

traversaro commented Feb 5, 2025 •

edited

Loading

traversaro Feb 5, 2025

		@@ -0,0 +1,3 @@
		The package gz-cmake4 provides CMake integration:

		find_package(gz-cmake4 CONFIG REQUIRED)

[gz-ports, sdformat] Update gz-ports #43265

Are you sure you want to change the base?

[gz-ports, sdformat] Update gz-ports #43265

Conversation

talregev commented Jan 14, 2025 • edited by WangWeiLin-MV Loading

talregev commented Jan 20, 2025

WangWeiLin-MV left a comment

Choose a reason for hiding this comment

talregev commented Jan 22, 2025 • edited Loading

WangWeiLin-MV commented Jan 23, 2025

BillyONeal Feb 4, 2025

Choose a reason for hiding this comment

dg0yt left a comment

Choose a reason for hiding this comment

dg0yt Jan 27, 2025

Choose a reason for hiding this comment

dg0yt Jan 27, 2025

Choose a reason for hiding this comment

dg0yt Jan 27, 2025

Choose a reason for hiding this comment

dg0yt Jan 27, 2025

Choose a reason for hiding this comment

BillyONeal commented Feb 4, 2025 • edited Loading

BillyONeal commented Feb 4, 2025

talregev commented Feb 4, 2025 • edited Loading

talregev commented Feb 4, 2025

dg0yt commented Feb 4, 2025

talregev commented Feb 4, 2025

dg0yt commented Feb 4, 2025

BillyONeal commented Feb 5, 2025

traversaro commented Feb 5, 2025 • edited Loading

traversaro Feb 5, 2025

Choose a reason for hiding this comment

talregev commented Jan 14, 2025 •

edited by WangWeiLin-MV

Loading

talregev commented Jan 22, 2025 •

edited

Loading

BillyONeal commented Feb 4, 2025 •

edited

Loading

talregev commented Feb 4, 2025 •

edited

Loading

traversaro commented Feb 5, 2025 •

edited

Loading