Remove VS based build #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
nibanks
approved these changes
Nov 18, 2024
Alan-Jowett
added a commit
that referenced
this pull request
Nov 19, 2024
This reverts commit 0305975.
Alan-Jowett
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily involves the removal of multiple build configuration files and their associated filters. These changes simplify the project structure by eliminating redundant or outdated configurations.
Key changes include:
Removal of build configurations and steps:
build-vsjob and its associated steps have been removed from.github/workflows/build.yml. This includes matrix configurations, environment variables, and various build and test steps.Removal of project files:
cxplat_test.vcxprojandcxplat_test.vcxproj.filtersfiles have been deleted from thecxplat/cxplat_testdirectory. These files contained configurations for building and filtering source files for thecxplat_testproject. [1] [2]cxplat_winkernel.vcxprojandcxplat_winkernel.vcxproj.filtersfiles have been deleted from thecxplat/src/cxplat_winkerneldirectory. These files contained configurations for building and filtering source files for thecxplat_winkernelproject. [1] [2]cxplat_winuser.vcxprojfile has been deleted from thecxplat/src/cxplat_winuserdirectory. This file contained configurations for building thecxplat_winuserproject.