Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fault injection crash #226

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Alan-Jowett
Copy link
Member

This pull request includes several changes to the src/ke.cpp file, focusing on improving the handling of the threadpool callback environment by using std::optional and making minor formatting adjustments.

Improvements to threadpool callback environment handling:

  • Included the <optional> header and changed the TP_CALLBACK_ENVIRON variable to use std::optional for better management of its initialization state. [1] [2]
  • Updated the initialization and cleanup logic for the threadpool callback environment to use std::optional methods, ensuring proper resource management. [1] [2] [3]

Formatting and minor code adjustments:

  • Added or adjusted function definitions and bodies to follow a consistent style, improving readability. [1] [2] [3] [4] [5] [6]
  • Removed unused variable threadpool_environment_initialized from the usersim_initialize_irql function.
  • Ensured the CreateThreadpoolTimer function call uses the value() method of std::optional for the threadpool callback environment.

Signed-off-by: Alan Jowett <[email protected]>
@Alan-Jowett Alan-Jowett merged commit 01df814 into microsoft:main Nov 4, 2024
9 checks passed
@Alan-Jowett Alan-Jowett deleted the fault_injection_crash branch November 4, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants