KeSetSystemGroupAffinityThread does not match kernel behavior #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
nibanks
reviewed
Apr 20, 2024
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
mtfriesen
reviewed
Apr 20, 2024
added 2 commits
April 20, 2024 12:24
Signed-off-by: Alan Jowett <[email protected]>
Signed-off-by: Alan Jowett <[email protected]>
|
@mtfriesen Can I get this reviewed? It's blocking fuzz testing. |
mtfriesen
reviewed
Apr 24, 2024
| @@ -224,11 +224,17 @@ KeSetSystemAffinityThreadEx(KAFFINITY affinity) | |||
| { | |||
| GROUP_AFFINITY old_affinity; | |||
| usersim_get_current_thread_group_affinity(&old_affinity); | |||
| // Reject affinities that are not valid for the current group. | |||
| // Assume that the affinity mask is contiguous. | |||
There was a problem hiding this comment.
FYI, I believe the affinity mask is guaranteed to be contiguous.
mtfriesen
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
KeSetSystemAffinityThreadEx(KAFFINITY affinity)function in thesrc/ke.cppfile. The change modifies the error handling mechanism. Instead of triggering a bug check when an error occurs, the function now returns 0.In detail:
src/ke.cpp: Modified theKeSetSystemAffinityThreadEx(KAFFINITY affinity)function to return 0 instead of triggering a bug check whenSetThreadAffinityMask(GetCurrentThread(), affinity)returns an error.