Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Directory.Build.props from parent if present #152

Merged

Conversation

Alan-Jowett
Copy link
Member

Resolve: #151

Add check if parent folder contains a Directory.Build.props file and import it if present.

Copy link
Contributor

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this solution only works if Directory.Build.props is exactly one level up.
Instead, see the suggestion in #151

@Alan-Jowett
Copy link
Member Author

I think this solution only works if Directory.Build.props is exactly one level up. Instead, see the suggestion in #151

This is the approach recommended in the MSSN:
https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-by-directory?view=vs-2022

@Alan-Jowett
Copy link
Member Author

@dthaler I am not understanding how the proposed solution in the linked issue would work. My understanding is that msbuild would only load the inner most directory.build.props when processing the vcxproj.

@dthaler
Copy link
Contributor

dthaler commented Jan 3, 2024

@Alan-Jowett please rebase

@Alan-Jowett Alan-Jowett force-pushed the optional_import_parent_build_prop branch from b69809b to e89258e Compare January 3, 2024 18:34
@Alan-Jowett
Copy link
Member Author

@Alan-Jowett please rebase

Rebased.

@dthaler
Copy link
Contributor

dthaler commented Jan 4, 2024

github reports "Merging can be performed automatically with 1 approving review." even though I approved, so I may not have permissions to be counted.

@nibanks nibanks merged commit 9ee14bb into microsoft:main Jan 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The use of Directory.Build.Props breaks consuming modules attempting to do ASAN builds
3 participants