Fix memory initialization bug in cxplat winkernel #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExAllocatePoolWithTag does not zero-initialize memory Signed-off-by: Dave Thaler <[email protected]>
dthaler
requested review from
Alan-Jowett,
mtfriesen and
nibanks
as code owners
Alan-Jowett
reviewed
Aug 31, 2023
Signed-off-by: Dave Thaler <[email protected]>
Alan-Jowett
approved these changes
Aug 31, 2023
mtfriesen
approved these changes
Aug 31, 2023
nibanks
reviewed
Aug 31, 2023
| @@ -7,12 +7,11 @@ | |||
| __drv_allocatesMem(Mem) _Must_inspect_result_ _Ret_writes_maybenull_(size) void* cxplat_allocate_with_tag( | |||
There was a problem hiding this comment.
Why have one function with a flag, requiring that extra branch for every caller? I'd expect most callers to always pick one or the other, so if you had two functions, you'd never need a branch.
There was a problem hiding this comment.
Fair point, though once #90 is done it will be moot as compiler optimization will remove the unused branch.
Still, probably good to split in the future, the code has been this way in ebpf-for-windows and just moved here, but can clean up going forward.
There was a problem hiding this comment.
I agree that the compiler should do a good job and optimize it away, but I never have much faith in compiler optimizations. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExAllocatePoolWithTag does not zero-initialize memory