Remove extra space #5238
Draft
Remove extra space #5238
+11
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Area: MTP
|
not sure why the single space ends up being much larger shift in the ansi code output. this is before removing the append:
|
|
also fixes normal terminal (with --no-ansi) |
|
Could you make a test with VSTest as well? |
|
It does not fix vstest, but I can see the same problem there with nunit. (while of course nunit is fine in mtp) |
Not sure what do you mean? What is the behavior when using VSTest before and after the change. I was expecting VSTest to probably be having the correct spacing already, and gets broken with the change. That's the guess I have. |
|
vstest output has incorrect spacing before and after the change, both for mstest and nunit. |
|
Nice. That was unexpected to me 😄 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the code is there since forever, and would always add a single extra space before the first "at".
Fix #5152