Add analyzer for duplicate data row #5144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
force-pushed
the
dup-datarow
branch
from
3457435 to
1051fdc
Compare
Youssef1313
force-pushed
the
dup-datarow
branch
from
abaf1b1 to
245cf50
Compare
Evangelink
reviewed
Mar 11, 2025
|
|
||
| if (!dataRowArguments.Add(attribute.ConstructorArguments)) | ||
| { | ||
| context.ReportDiagnostic((attribute.ApplicationSyntaxReference?.GetSyntax(context.CancellationToken).GetLocation() ?? Location.None).CreateDiagnostic(Rule)); |
There was a problem hiding this comment.
Is there no helper for that on roslyn-analyzers? Or maybe it's already available in the code I copied.
| @@ -573,4 +573,10 @@ The type declaring these methods should also respect the following rules: | |||
| <data name="UseConditionBaseWithTestClassMessageFormat" xml:space="preserve"> | |||
| <value>The attribute '{0}' which derives from 'ConditionBaseAttribute' should be used only on classes marked with `TestClassAttribute`</value> | |||
| </data> | |||
| <data name="DuplicateDataRowTitle" xml:space="preserve"> | |||
| <value>A duplicate 'DataRow' attribute is found</value> | |||
There was a problem hiding this comment.
Maybe something like Avoid duplicated 'DataRow' entries? or Do not duplicate 'DataRow' entries
| <value>A duplicate 'DataRow' attribute is found</value> | ||
| </data> | ||
| <data name="DuplicateDataRowMessageFormat" xml:space="preserve"> | ||
| <value>Do not duplicate 'DataRow' attributes. This is usually a copy/paste error.</value> |
There was a problem hiding this comment.
Just wondering if we should point out the indexes of duplicated entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5085