Only push output device messages to Test Explorer, don't push logs #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs are intended to be used for diagnosing. They shouldn't be localized and they shouldn't be pushed to Test Explorer.
Youssef1313
commented
Nov 27, 2024
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/ServerModeTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Nov 28, 2024
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/ServerModePerCallOutputDevice.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/ServerModePerCallOutputDevice.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/ServerModePerCallOutputDevice.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Area: Server Mode
Area: MTP
|
Azure Pipelines successfully started running 1 pipeline(s). |
Youssef1313
commented
Dec 3, 2024
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/ProxyPlatformOutputDevice.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Dec 4, 2024
Evangelink
reviewed
Dec 4, 2024
src/Platform/Microsoft.Testing.Platform/Hosts/ServerTestHost.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Dec 4, 2024
src/Platform/Microsoft.Testing.Platform/OutputDevice/ProxyOutputDevice.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Dec 4, 2024
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Dec 4, 2024
src/Platform/Microsoft.Testing.Platform/ServerMode/JsonRpc/ServerModePerCallOutputDevice.cs
Show resolved
Hide resolved
Evangelink
reviewed
Dec 4, 2024
...rm.Acceptance.IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Dec 4, 2024
...rm.Acceptance.IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
Evangelink
previously approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Some nits and questions but LGTM.
Thanks for the massive work here @Youssef1313! And thanks @MarcoRossignoli for technical consulting <3
Evangelink
approved these changes
Dec 4, 2024
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs are intended to be used for diagnosing. They shouldn't be localized and they shouldn't be pushed to Test Explorer.
Fixes #4213
Linked to AB#2275339