[main] Update dependencies from microsoft/testfx #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…231220.9 MSTest From Version 3.2.0-preview.23620.1 -> To Version 3.2.0-preview.23620.9
| // DoNotParallelize set for TestAssetName | ||
| // There are a total of 2 classes - C1 (3 tests), C2 (3 tests) with a sleep of TestMethodWaitTimeInMS. | ||
| // So this should not exceed 5 * TestMethodWaitTimeInMS seconds + 2.5 seconds overhead. | ||
| ValidateTestRunTime((5 * TestMethodWaitTimeInMS) + OverheadTimeInMS); | ||
|
|
||
| // ValidateTestRunTime((5 * TestMethodWaitTimeInMS) + OverheadTimeInMS); |
There was a problem hiding this comment.
@Evangelink I've removed the time validation, hard to predict now that we're increasing the load on the machine, maybe if we want some time testing we should have another step with "time regression/measure" to run in sequence or in a controlled dop from process/tests perspective.
MarcoRossignoli
deleted the
darc-main-b344add7-5656-4003-871d-cd90dcf9d230
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/microsoft/testfx