Move away from nuspec for MSTest metapackage

microsoft · Jan 29, 2025 · 6a261a7 · 6a261a7
1 parent f524234
commit 6a261a7
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 136 deletions.
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -39,6 +39,7 @@
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="$(MicrosoftCodeAnalysisVersion)" />
     <PackageVersion Include="Microsoft.Diagnostics.NETCore.Client" Version="0.2.553101" />
     <PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="$(MicrosoftTestingExtensionsCodeCoverageVersion)" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkVersion)" />
     <PackageVersion Include="Microsoft.TestPlatform.AdapterUtilities" Version="$(MicrosoftNETTestSdkVersion)" />
     <PackageVersion Include="Microsoft.TestPlatform.ObjectModel" Version="$(MicrosoftNETTestSdkVersion)" />
     <PackageVersion Include="Microsoft.TestPlatform.TranslationLayer" Version="$(MicrosoftNETTestSdkVersion)" />

diff --git a/samples/Playground/Playground.csproj b/samples/Playground/Playground.csproj
@@ -22,7 +22,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" VersionOverride="$(MicrosoftNETTestSdkVersion)" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/src/Package/MSTest/MSTest.NonWindows.nuspec b/src/Package/MSTest/MSTest.NonWindows.nuspec
diff --git a/src/Package/MSTest/MSTest.csproj b/src/Package/MSTest/MSTest.csproj
@@ -1,16 +1,14 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.0</TargetFrameworks>
-  </PropertyGroup>
+    <TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">netstandard2.0;$(NetFrameworkMinimum);$(SupportedNetFrameworks);$(UwpMinimum);$(WinUiMinimum)</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">$(SupportedNetFrameworks);netstandard2.0</TargetFrameworks>
 
-  <PropertyGroup>
+    <IncludeBuildOutput>false</IncludeBuildOutput>
     <IsPackable>true</IsPackable>
-    <NuspecFile Condition=" '$(OS)' == 'Windows_NT' ">MSTest.nuspec</NuspecFile>
-    <NuspecFile Condition=" '$(OS)' != 'Windows_NT' ">MSTest.NonWindows.nuspec</NuspecFile>
-    <NuspecBasePath>$(OutputPath)</NuspecBasePath>
     <PackageId>MSTest</PackageId>
     <PackageTags>MSTest TestFramework TestAdapter VisualStudio Unittest MSTestV2 Microsoft</PackageTags>
+    <PackageReadmeFile>PACKAGE.md</PackageReadmeFile>
     <PackageDescription>
       MSTest is Microsoft supported Test Framework.
 
@@ -23,19 +21,21 @@
       - .NET 6.0 Windows.18362+
       - UWP 10.0.16299
     </PackageDescription>
-    <!-- Nothing in lib but that's expected -->
-    <NoWarn>$(NoWarn);NU5128</NoWarn>
   </PropertyGroup>
 
-  <ItemGroup Label="NuGet">
-    <NuspecProperty Include="TestPlatformVersion=$(MicrosoftNETTestSdkVersion)" />
-    <NuspecProperty Include="RepoRoot=$(RepoRoot)" />
+  <ItemGroup>
+    <ProjectReference Include="..\..\Adapter\MSTest.TestAdapter\MSTest.TestAdapter.csproj" />
+    <ProjectReference Include="..\..\TestFramework\TestFramework.Extensions\TestFramework.Extensions.csproj" />
+    <ProjectReference Include="..\..\Analyzers\MSTest.Analyzers\MSTest.Analyzers.csproj" />
   </ItemGroup>
 
   <ItemGroup>
-    <!-- Not a real dependency but it ensures correct build order -->
-    <ProjectReference Include="..\..\Adapter\MSTest.TestAdapter\MSTest.TestAdapter.csproj" />
+    <!-- Microsoft.NET.Test.Sdk package is referenced by build system, so omitting it. -->
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Condition="'$(TargetFramework)' != '$(UwpMinimum)'" />
   </ItemGroup>
 
+  <ItemGroup>
+    <None Include="$(PackageReadmeFile)" Pack="true" PackagePath="\" />
+  </ItemGroup>
 
 </Project>
diff --git a/src/Package/MSTest/MSTest.nuspec b/src/Package/MSTest/MSTest.nuspec