-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement --stepsApi
configuration flag for storybook v8, v9 and vNext support
#74
Draft
Hotell
wants to merge
15
commits into
microsoft:storybook7
Choose a base branch
from
Hotell:feat/add-storybook-9-support
base: storybook7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stories for Steps
…any story processing occurred
…undefined check when obtaining steps via findSteps fn
…ely if any story processing occurred
--stepsApi
configuration flag for storybook v8, v9 and vNext support
--stepsApi
configuration flag for storybook v8, v9 and vNext support--stepsApi
configuration flag for storybook v8, v9 and vNext support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requirements:
Features
Starting SB v8 using storyStore
raw
API is deprecated and will be removed in SB v9 (https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#storystore-and-methods-deprecated).For that reason, we won't be able to render stories dynamically to traverse React Tree to obtains
StoryWright
componentsteps
prop.This PR implements new API to obtain stories which uses stable/non-deprecated api to obtain stories dynamically via
Preview.extract()
Using the new API
Your steps need to be defined via
parameters
rather than usingdecorators
with<StoryWright/>
componentBefore:
After:
Important
In order to avoid breaking changes immediately and to properly support SB versions ranges from V7 to V9, the new API can be turned on by setting
--stepsApi=parameters
Related Issues