Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devtools] Improve ActivityDetails Preview UI #86

Merged
merged 7 commits into from
Mar 13, 2025
Merged

[devtools] Improve ActivityDetails Preview UI #86

merged 7 commits into from
Mar 13, 2025

Conversation

corinagum
Copy link
Contributor

Fix: #18

  • Update cursor rules - seems to work ok.
  • Add documentation on devtools dev mode
  • Fix focus stealing by MessageActionsToolbar & improve a11y
  • Clean up Activity Details UI
    • truncated text if overflow
    • no horizontal scrollbar
    • empty non-primitives are not expandable
    • tooltips
    • reduce spacing if all children are primitive values
    • Restore collapsed non-primitives inline instead of [...] or {...}

Activity details with non-expanded views and tooltip
image

Activity details with expanded views
image

@aacebo aacebo merged commit 55442dd into main Mar 13, 2025
5 checks passed
@aacebo aacebo deleted the cg/ff branch March 13, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aacebo aacebo aacebo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[devtools] Fast-follow
2 participants
@corinagum @aacebo