Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools] Rework ComposeBox (ContentEditableArea), messageUpdate, and more #116

Merged
merged 12 commits into from
Mar 31, 2025

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Mar 28, 2025

fix: #40
fix: #61
fix: #66

image

image
image
image
image

  • Created ContentEditableArea to replace FluentUI's TextArea - visually, they are identical, but allow for a lot of better UX
  • Attachments can render in the ComposeBox or EditComposeBox (just cards for now, still...)
  • User can update their messages by clicking the edit button (pencil) in the MessageActionsToolbar
  • Better usage of React performance hooks
  • You can add card attachments to messages you are editing
  • if you type in the ComposeBox, then press "Open card designer", then attach a card, your message that you were typing will be preserved. Same for if you made changes to your messages while editing. Focus will return to the ContentEditableArea you were using before sidetracking to cards.
  • Moved location of Toast notifications to top-middle of screen - bottom right was blocking the send button
  • Improve markdown handling - preserve line breaks
  • Added Adaptive Card target widths to hopefully work if card contains targetWidth

@corinagum corinagum marked this pull request as ready for review March 28, 2025 04:31
Copy link
Contributor

@heyitsaamir heyitsaamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda hard to review b/c of size. It'd be good to keep PRs atleast somewhat reviewable, tho i understand it's not always possible

@aacebo aacebo merged commit b07c11a into main Mar 31, 2025
5 checks passed
@aacebo aacebo deleted the cg/cea branch March 31, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants