Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system prompt sending, and add comment #105

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Fix system prompt sending, and add comment #105

merged 2 commits into from
Mar 21, 2025

Conversation

heyitsaamir
Copy link
Contributor

@heyitsaamir heyitsaamir commented Mar 20, 2025 •
edited
Loading

  • System prompts right now were being pushed after the messages. We want them to be at the top of the messages array.
  • Remove trailing slashes from API urls if they exist.
  • Added a comment that makes it more clear the instructions are commonly referred to as system prompts.

@heyitsaamir heyitsaamir requested review from aacebo and corinagum March 20, 2025 21:06
@aacebo aacebo merged commit 219e864 into main Mar 21, 2025
5 checks passed
@aacebo aacebo deleted the aamirj/fixoai branch March 21, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aacebo aacebo aacebo approved these changes

@corinagum corinagum Awaiting requested review from corinagum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyitsaamir @aacebo