Python: .Net: MEVD Preview VNext (DRAFT) #11028
Draft
+6,164
−8,647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And the obsoleted Filter to OldFilter. Continues #10273.
### Description Merging changes from main and resolving merge conflicts ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Vincent Biret <[email protected]> Co-authored-by: Evan Mattson <[email protected]> Co-authored-by: Dmytro Struk <[email protected]> Co-authored-by: Chris <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tao Chen <[email protected]> Co-authored-by: Roger Barreto <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: Estefanía Tenorio <[email protected]> Co-authored-by: davidpene <[email protected]> Co-authored-by: ThDuquennoy <[email protected]> Co-authored-by: Thomas DUQUENNOY <[email protected]> Co-authored-by: Eduard van Valkenburg <[email protected]> Co-authored-by: Evan Mattson <[email protected]> Co-authored-by: Rob Emanuele <[email protected]> Co-authored-by: K. Andrew Parker <[email protected]> Co-authored-by: SergeyMenshykh <[email protected]> Co-authored-by: jenfoxbot <[email protected]> Co-authored-by: Ben Thomas <[email protected]> Co-authored-by: Ben Thomas <[email protected]> Co-authored-by: Adit Sheth <[email protected]> Co-authored-by: Adit Sheth <[email protected]> Co-authored-by: ふぁー <[email protected]> Co-authored-by: Vincent Biret <[email protected]> Co-authored-by: David A. Torres <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Atiqur Rahman Foyshal <[email protected]> Co-authored-by: Md. Atiqur Rahman Foyshal <[email protected]> Co-authored-by: Fabian Williams <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Ram.Type-0 <[email protected]> Co-authored-by: Tommy Falgout <[email protected]> Co-authored-by: Gary Tang <[email protected]> Co-authored-by: Eirik Tsarpalis <[email protected]> Co-authored-by: Tommaso Stocchi <[email protected]> Co-authored-by: Chris Rickman <[email protected]> Co-authored-by: Devis Lucato <[email protected]> Co-authored-by: K. Andrew Parker <[email protected]> Co-authored-by: Jose Luis Latorre Millas <[email protected]> Co-authored-by: Carsten Lemm <[email protected]> Co-authored-by: Stephen Toub <[email protected]> Co-authored-by: Musale Martin <[email protected]> Co-authored-by: Ross Smith <[email protected]>
This reverts commit 865d67e.
### Motivation and Context Adding hybrid search to March release branch ### Description Adding hybrid search to March release branch ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
fixes #10416 --------- Co-authored-by: westey <[email protected]> Co-authored-by: Shay Rojansky <[email protected]>
…oft/semantic-kernel into feature-vector-data-preb1
This reverts commit 864b707.
fixes #10420 --------- Co-authored-by: westey <[email protected]>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Related: #10596 This PR enhances the vector store functionality by adding builder pattern implementations and logging decorators for key vector data interfaces, along with supporting utilities and DI integration. Interfaces handled: - `IKeywordHybridSearch<TRecord>` - `IVectorizableTextSearch<TRecord>` - `IVectorizedSearch<TRecord>` - `IVectorStore` - `IVectorStoreRecordCollection<TKey, TRecord>` Class types added: - Builders: implement a pipeline pattern with `Use` and `Build` methods. - Logging Extensions: provide reusable logging methods for tasks and enumerables, handling success, failure and cancellation. - Logging Decorators: wrap the interfaces to add logging by using `LoggingExtensions` reusable logging methods. - Builder Extensions: Add `AsBuilder` methods to convert service instances into builders. - Logging Builder Extensions: Add `UseLogging` methods to integrate logging into builder pipelines. - Service Collection Extensions: Add `Add{T}` and `AddKeyed{T}` methods for DI registration with configurable lifetimes. Other changes: - Split `Verify` class into `Verify` and `KernelVerify` in order to be able to use `Verify` methods in `Microsoft.Extensions.VectorData` package without a reference to Semantic Kernel specific logic, like `ValidPluginName`, `ValidFunctionName` etc. - Added unit tests for new classes and methods. - Added usage example in `Concepts/Memory` folder. ### Usage example Logging with manual registration: ```csharp var vectorStore = new InMemoryVectorStore() .AsBuilder() .UseLogging(this.LoggerFactory) .Build(); ``` Logging with DI: ```csharp serviceCollection.AddInMemoryVectorStore(); serviceCollection .AddVectorStore(s => s.GetRequiredService<InMemoryVectorStore>()) .UseLogging(this.LoggerFactory); ``` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
Aligning with MEAI; this helps netfx users under net472 ([link](https://github.com/roji/semantic-kernel/pull/new/net462)).
…oft/semantic-kernel into feature-vector-data-preb2
markwallace-microsoft
removed
the
python
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
contributes to #10194 --------- Co-authored-by: Shay Rojansky <[email protected]>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Temporarily remove logging to add it back later when API is stable. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
### Motivation and Context Changing this simplifies the interface to make methods more discoverable. #11276 ### Description Removing batch from the batch CRUD operation name, since they do not clash with the non batch overloads. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist