Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-app projects out of 'apps' and into 'libraries' #3331

Merged
merged 3 commits into from
Apr 9, 2022
Merged

Move non-app projects out of 'apps' and into 'libraries' #3331

merged 3 commits into from
Apr 9, 2022

Conversation

iclanton
Copy link
Member

@iclanton iclanton commented Apr 8, 2022 •
edited
Loading

This PR specifically moves @microsoft/rush-lib and @microsoft/api-extractor-model to the libraries folder.

@octogonz
Copy link
Collaborator

octogonz commented Apr 8, 2022

#3321 is about to get merged tomorrow. Could we do this afterwards to avoid creating a merge conflict?

@iclanton
Copy link
Member Author

iclanton commented Apr 8, 2022

#3321 is about to get merged tomorrow. Could we do this afterwards to avoid creating a merge conflict?

Sure

octogonz
octogonz approved these changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@octogonz octogonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #3321 has been merged, so you're good to proceed with this PR. (Double-check that there isn't a merge conflict with those changes.)

@iclanton iclanton merged commit c7aef03 into microsoft:master Apr 9, 2022
@iclanton iclanton deleted the move-non-apps branch April 9, 2022 01:25
@zelliott
Copy link
Contributor

zelliott commented Apr 9, 2022 •
edited
Loading

Does this also need to be renamed from apps/ to libraries/?

rushstack/.vscode/launch.json

Line 28 in 57d2b0c

"program": "${workspaceRoot}/apps/rush-lib/lib/start.js",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octogonz octogonz octogonz approved these changes

@dmichon-msft dmichon-msft dmichon-msft approved these changes

@apostolisms apostolisms Awaiting requested review from apostolisms

@sachinjoseph sachinjoseph Awaiting requested review from sachinjoseph

@D4N14L D4N14L Awaiting requested review from D4N14L

@patmill patmill Awaiting requested review from patmill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iclanton @octogonz @zelliott @dmichon-msft