feat(capture): add managed storage account support #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qingchuan Hao <[email protected]>
Signed-off-by: Qingchuan Hao <[email protected]>
mainred
commented
Jul 31, 2024
Signed-off-by: Qingchuan Hao <[email protected]>
Signed-off-by: Qingchuan Hao <[email protected]>
Signed-off-by: Qingchuan Hao <[email protected]>
mainred
force-pushed
the
capture-managed-storage-account
branch
from
f327a41 to
bd8452e
Compare
Signed-off-by: Qingchuan Hao <[email protected]>
Signed-off-by: Qingchuan Hao <[email protected]>
…ed-storage-account
rbtr
requested review from
jimassa,
rbtr and
nddq
and removed request for
MikeZappa87 and
spencermckee
rbtr
added
type/enhancement
timraymond
reviewed
Aug 5, 2024
Signed-off-by: Qingchuan Hao <[email protected]>
…ed-storage-account
mainred
force-pushed
the
capture-managed-storage-account
branch
from
eb502f1 to
9fd901a
Compare
Signed-off-by: Qingchuan Hao <[email protected]>
mainred
force-pushed
the
capture-managed-storage-account
branch
from
9fd901a to
45392cb
Compare
Signed-off-by: Qingchuan Hao <[email protected]>
jimassa
reviewed
Aug 6, 2024
Signed-off-by: Qingchuan Hao <[email protected]>
Signed-off-by: Qingchuan Hao <[email protected]>
mainred
commented
Aug 8, 2024
rbtr
reviewed
Aug 13, 2024
deploy/legacy/manifests/controller/helm/retina/templates/operator.yaml
Outdated
Show resolved
Hide resolved
deploy/legacy/manifests/controller/helm/retina/templates/operator.yaml
Outdated
Show resolved
Hide resolved
|
LGTM on @rbtr 's feedback. |
rbtr
previously approved these changes
Aug 23, 2024
rbtr
approved these changes
Aug 23, 2024
ritwikranjan
pushed a commit
to ritwikranjan/retina
that referenced
this pull request
Aug 28, 2024
This PR introduces a managed storage account solution to Retina Capture, which managed the storage account resources on behalf the user under the azure resource group specified in the azure credential config file. After this, the user does not need to create even the secret and the captured network artificats will be uploaded to the storage account. If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request. - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. - After updating the helm charts - a storage account and a management policy rule to auto-delete blob after 7 days are created  - After applying a Capture - a blob container with retention policy is created  - a k8s secret is created  - network artifacts are uploaded the container after Capture duration  - After deleting the capture - the secret is deleted  Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Qingchuan Hao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a managed storage account solution to Retina Capture, which managed the storage account resources on behalf the user under the azure resource group specified in the azure credential config file.
After this, the user does not need to create even the secret and the captured network artificats will be uploaded to the storage account.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.