feat: conntrack for data aggregation #283
Closed
+14,947
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddq
added
type/enhancement
vakalapa
reviewed
Apr 19, 2024
vakalapa
reviewed
Apr 19, 2024
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
|
Pull request closed due to inactivity. |
| * @arg flags The flags of the packet. | ||
| * Returns true if the packet should be report to userspace. False otherwise. | ||
| **/ | ||
| static __always_inline __attribute__((unused)) bool ct_process_packet(struct ct_v4_key key, __u8 flags) { |
There was a problem hiding this comment.
Write out the algorithm as steps and see how to refactor it in a more manageable way. Currently code complexity (branching) feels too high.
Signed-off-by: Quang Nguyen <[email protected]>
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
# Description Part of #283, broken down for ease of review. Testing results will be added in #624 ## Related Issue If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request. ## Checklist - [ ] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [ ] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [ ] I have correctly attributed the author(s) of the code. - [ ] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Quang Nguyen <[email protected]>
rectified95
reviewed
Aug 29, 2024
| default: | ||
| // Some kind of option. | ||
| // Since each option is at least 2 bytes long, we need to check that adding 2 to the pointer will not go past the end of the packet. | ||
| if (tcp_options_cur_ptr + 2 > tcp_opt_end_ptr || tcp_options_cur_ptr + 2 > (__u8 *)data_end) { |
There was a problem hiding this comment.
when possible avoid magic nubmers like this in non-test code, even though there's a comment
|
closing in favor of #624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a naive conntrack map. Related to #138. Smaller PRs will be open from this PR for ease of review.
packetparser#590 (Optional)Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.