Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Refactor): Update function comment in Watcher() method #199

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

sajjadvaezi
Copy link
Contributor

@sajjadvaezi sajjadvaezi commented Mar 31, 2024

refactor(docs): Update function comment in Watcher() method

Adjusted the function comment in the Watcher() method from '// NewApiServerWatcher creates a new apiserver watcher.' to '// Watcher creates a new apiserver watcher.'

@sajjadvaezi sajjadvaezi requested a review from a team as a code owner March 31, 2024 14:55
@rbtr rbtr added area/documentation Improvements or additions to documentation lang/go The Go Programming Language type/fix Fixes something priority/2 P2 labels Mar 31, 2024
@vakalapa vakalapa changed the title Refactor: Update function comment in Watcher() method fix(Refactor): Update function comment in Watcher() method Apr 2, 2024
@vakalapa vakalapa enabled auto-merge April 2, 2024 15:51
@rbtr
Copy link
Collaborator

rbtr commented Apr 2, 2024

@sajjadvaezi Can you please cryptographically sign your commits, and also add a Signed-off-By in the commit message?

This Verified in the commits page indicates cryptographic signature:
image

It is a merge requirement that all commits be signed and have a Signed-off-By message.
See #197 for more info

Adjusted the function comment in the Watcher() method from '// NewApiServerWatcher creates a new apiserver watcher.' to '// Watcher creates a new apiserver watcher.'

Signed-off-by: sajjad <[email protected]>
auto-merge was automatically disabled April 2, 2024 18:30

Head branch was pushed to by a user without write access

@sajjadvaezi
Copy link
Contributor Author

is it okay now ?

@rbtr rbtr enabled auto-merge April 2, 2024 18:39
@rbtr
Copy link
Collaborator

rbtr commented Apr 2, 2024

Looks good!

@rbtr rbtr added this pull request to the merge queue Apr 2, 2024
Merged via the queue into microsoft:main with commit 6d74b85 Apr 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation lang/go The Go Programming Language priority/2 P2 type/fix Fixes something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants