Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: packet traces feature for Retina CLI #198

Closed
wants to merge 6 commits into from
Closed

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Mar 29, 2024

Description

Readding this WIP trace feature for Retina CLI to the repo. Also remove a bunch of Apache License since we are using MIT now.

Related Issue

Will open an issue to keep track of development.

@nddq nddq added type/enhancement New feature or request lang/go The Go Programming Language labels Mar 29, 2024
@nddq nddq requested a review from a team as a code owner March 29, 2024 22:14
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of these are (the original?) 3rd party licenses and should stay. The license of the file supersedes the default license of the repo

test/plugin/dns/main_linux.go Outdated Show resolved Hide resolved
test/utsummary/main.go Outdated Show resolved Hide resolved
@nddq nddq self-assigned this Mar 29, 2024
@@ -0,0 +1,70 @@
# TraceConfiguration

> **Note:** This feature is currently under experimental development.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment here that this is not implemented in bold headings ?

Copy link

github-actions bot commented May 4, 2024

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions bot added the meta/waiting-for-author Blocked and waiting on the author label May 4, 2024
@nddq nddq removed the meta/waiting-for-author Blocked and waiting on the author label May 8, 2024
Copy link

github-actions bot commented Jun 8, 2024

This PR will be closed in 7 days due to inactivity.

@github-actions github-actions bot added the meta/waiting-for-author Blocked and waiting on the author label Jun 8, 2024
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this Jun 16, 2024
@github-actions github-actions bot deleted the feat/traceCLI branch June 16, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins lang/go The Go Programming Language meta/waiting-for-author Blocked and waiting on the author priority/1 P1 type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants