fix: run conditions on step level when using matrix strategy. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osoft/retina into jmassa/run_e2e_on_merge_queue Signed-off-by: Jacques Massa <[email protected]>
Signed-off-by: Jacques Massa <[email protected]>
Signed-off-by: Jacques Massa <[email protected]>
Signed-off-by: Jacques Massa <[email protected]>
jimassa
changed the title
snguyen64
approved these changes
Mar 29, 2024
Signed-off-by: Jacques Massa <[email protected]>
…soft/retina into jmassa/skip_codeQ_mergeQueue
hainenber
pushed a commit
to hainenber/retina
that referenced
this pull request
Apr 4, 2024
…oft#195) # Description Condition on job runs, before matrix strategy, which makes some require job not run in merge queue. This brings the condition on the steps level to allow matrix strategy to create jobs. ## Related Issue If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request. ## Checklist - [ ] I have read the [contributing documantation](https://retina.sh/docs/contributing). - [ ] I signed and signed-off the commits (`git commit -S -s ...`) - [ ] I have correctly attributed the author(s) of the code. - [ ] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Jacques Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Condition on job runs, before matrix strategy, which makes some require job not run in merge queue. This brings the condition on the steps level to allow matrix strategy to create jobs.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...)Screenshots (if applicable)
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.