Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache Go's build artifacts in dockerfiles #159

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Mar 27, 2024

This update caches Go’s build artifacts, speeding up image builds and avoiding rebuilds for unchanged packages, thus streamlining development.

@nddq nddq added type/enhancement New feature or request area/infra Test, Release, or CI Infrastructure labels Mar 27, 2024
@nddq nddq self-assigned this Mar 27, 2024
@nddq nddq requested a review from a team as a code owner March 27, 2024 16:49
@nddq nddq force-pushed the feat/cachedbuild branch from 74c6a60 to cf4c52c Compare March 27, 2024 16:49
rbtr
rbtr previously approved these changes Mar 27, 2024
@rbtr
Copy link
Collaborator

rbtr commented Mar 27, 2024

@nddq you need to amend and sign all previous commits (or squash to a single signed commit)

@rbtr
Copy link
Collaborator

rbtr commented Mar 27, 2024

wonder if we could do this to CodeQL somehow so that the Windows build would take less than 90 minutes? 😭

@nddq
Copy link
Contributor Author

nddq commented Mar 27, 2024

@nddq you need to amend and sign all previous commits (or squash to a single signed commit)

i did add a -S to every git commit though? Is it not showing up?

@rbtr rbtr enabled auto-merge (squash) March 27, 2024 19:33
@rbtr
Copy link
Collaborator

rbtr commented Mar 27, 2024

i did add a -S to every git commit though? Is it not showing up?

not on cf4c52c92544e268f589997041bf5678c1844ebb
you can see which ones have the Verified badge here https://github.com/microsoft/retina/pull/159/commits

@nddq nddq force-pushed the feat/cachedbuild branch 3 times, most recently from 6edea93 to ff4967c Compare March 27, 2024 20:53
@nddq nddq force-pushed the feat/cachedbuild branch from ff4967c to 96f2b03 Compare March 27, 2024 20:55
@rbtr rbtr merged commit cb197d8 into main Mar 27, 2024
15 checks passed
@rbtr rbtr deleted the feat/cachedbuild branch March 27, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Test, Release, or CI Infrastructure type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants