Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update instructions for helm install to use GHCR #142

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

rbtr
Copy link
Collaborator

@rbtr rbtr commented Mar 26, 2024

Updates installation guide in docs and README to reflect that the Helm Chart is now published on GHCR and may be installed directly without cloning the repo or running the Make commands.

Follow up to the fix to #107 (#127) and documents it as requested here.

fixes #163

@rbtr rbtr requested a review from a team as a code owner March 26, 2024 18:07
@rbtr rbtr self-assigned this Mar 26, 2024
@rbtr rbtr added the area/documentation Improvements or additions to documentation label Mar 26, 2024
@rbtr rbtr enabled auto-merge (squash) March 26, 2024 18:08
@rbtr
Copy link
Collaborator Author

rbtr commented Mar 26, 2024

cc @seilorjunior

@rbtr rbtr force-pushed the docs/helm branch 2 times, most recently from 16e2a9b to 3cdd5e5 Compare March 26, 2024 18:16
timraymond
timraymond previously approved these changes Mar 27, 2024
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried out the steps in README verbatim and they work as expected. LGTM 👍

@rbtr
Copy link
Collaborator Author

rbtr commented Mar 27, 2024

@timraymond rebased to resolve conflicts, can I get your ✅ again please?

@rbtr rbtr merged commit 12f4f89 into microsoft:main Mar 28, 2024
16 checks passed
@rbtr rbtr deleted the docs/helm branch March 28, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make helm-install does not install the latest image
3 participants