Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change parse ts func in packetparser #140

Merged
merged 12 commits into from
Mar 29, 2024
Merged

chore: change parse ts func in packetparser #140

merged 12 commits into from
Mar 29, 2024

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Mar 26, 2024

Build and deploy in a test cluster and verified that TSVal and TSErc are parsed correctly (latency values are populated)
image

@rbtr rbtr added this to the v0.0.3 milestone Mar 26, 2024
@nddq nddq force-pushed the feat/parseTS branch 2 times, most recently from 6804a33 to cf14e11 Compare March 27, 2024 16:09
@nddq nddq self-assigned this Mar 27, 2024
@nddq nddq marked this pull request as ready for review March 27, 2024 16:09
@nddq nddq requested a review from a team as a code owner March 27, 2024 16:09
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Testing Done section?

@nddq nddq enabled auto-merge (squash) March 28, 2024 20:28
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@nddq nddq merged commit 9ccb6e5 into main Mar 29, 2024
17 checks passed
@nddq nddq deleted the feat/parseTS branch March 29, 2024 17:04
hainenber pushed a commit to hainenber/retina that referenced this pull request Apr 4, 2024
Build and deploy in a test cluster and verified that TSVal and TSErc are
parsed correctly.

---------

Signed-off-by: Quang Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants