Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: captures document link not working. #1327

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Feb 9, 2025

Description

Hiya, while doing #1326, I've noticed that the document link is not working. this PR is made with an intent to fix that.

You can see working Captures here - * https://github.com/Tatsinnit/retina/tree/fix/doclink?tab=readme-ov-file whereas the main repo has broken link for captueres which goes to page not found.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshot:

Screenshot 2025-02-10 at 8 38 19 AM

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@Tatsinnit Tatsinnit requested a review from a team as a code owner February 9, 2025 19:43
@Tatsinnit Tatsinnit requested review from rbtr and byte-msft February 9, 2025 19:43
Copy link
Contributor

@kamilprz kamilprz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thank you!

@kamilprz kamilprz added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@kamilprz kamilprz added this pull request to the merge queue Feb 10, 2025
Merged via the queue into microsoft:main with commit f0b5ae5 Feb 10, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants