Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Conntrack GC running in Retina default #1323

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

manojks1999
Copy link

Description

Please provide a brief description of the changes made in this pull request.

Related Issue

#1314

Checklist

  • [ * ] I have read the contributing documentation.
  • [ * ] I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • [ * ] I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • [ * ] I have followed the project's style guidelines.
  • [ * ] I have updated the documentation, if necessary.
  • [ * ] I have added tests, if applicable.

@manojks1999 manojks1999 requested a review from a team as a code owner February 6, 2025 19:35
@manojks1999
Copy link
Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

Copy link
Member

@SRodi SRodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manojks1999, thanks for opening this PR! Can you please fix all unsuccessful checks? If needed you can "convert to draft" and then switch to "ready for review" once you are done.

@manojks1999
Copy link
Author

@SRodi , I have fixed the runtime build, able to create a make file locally, but unable to create a docker file as some dependency issue in config.

@manojks1999
Copy link
Author

@SRodi, I have made changes now we are getting the correct output,

ts=2025-02-08T16:22:14.299Z level=info caller=conntrack/conntrack_linux.go:101 msg="Skipping Conntrack GC loop as packetparser plugin is not enabled"

Please verify once and also can you provide command related to helm install
with respect to packetparser both enabled and disabled, so that I can test your command too, so that have a extra verification.

@manojks1999 manojks1999 changed the title Fix [1314] Conntrack GC running in Retina default fix: fix Conntrack GC running in Retina default Feb 9, 2025
@manojks1999
Copy link
Author

manojks1999 commented Feb 9, 2025

@SRodi Added a set method for the widows files too.

Copy link
Member

@SRodi SRodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manojks1999 Thanks for looking into this. I don't think we want and/or is necessary to add the config to Conntrack struct. Have you looked into adding a conditional when we start Conntrack?

// run conntrack GC
ct, err := conntrack.New()

Also, for development environment set up instructions please see this doc https://retina.sh/docs/Contributing/development

Make sure this is tested and you add test results (or screenshots) to the PR description when possible. Please also provide a clear description for this PR.

I'll mark this PR as draft for now, once you have all bits in order, please feel free to change it to "Ready to review". Thanks again!

@SRodi SRodi marked this pull request as draft February 11, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants