Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mc): Add function to override logger for sensitive outputs #1286

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Jan 30, 2025

Description

  • add fetchSensitiveOutputs function to override default logger to prevent sensitive outputs from being logged
  • add checkRetinaPodsRunning function to check if Retina pods are running
  • add make target for formatting both OpenTofu and go code
  • modify make test target to run test ONLY for TestRetinaKindIntegration till we get cloud creds
  • refactor tests to use new func

Related Issue

#1267

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@SRodi SRodi requested a review from a team as a code owner January 30, 2025 11:53
@SRodi SRodi self-assigned this Jan 30, 2025
@SRodi SRodi requested a review from alexcastilio January 30, 2025 15:50
@SRodi SRodi enabled auto-merge January 30, 2025 15:58
@SRodi SRodi added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
@SRodi SRodi added this pull request to the merge queue Jan 30, 2025
Merged via the queue into microsoft:main with commit ae716a5 Jan 30, 2025
29 checks passed
@SRodi SRodi deleted the test/mc-sensitive-outputs branch January 30, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants