fix: kapinger use service IP instead of name #1283
Open
+194
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRodi
reviewed
Jan 30, 2025
| sync.RWMutex | ||
| serviceInformer cache.SharedIndexInformer | ||
|
|
||
| ips []string |
There was a problem hiding this comment.
Although a slice is more memory-efficient, if the order of IPs is not important, have you considered using a map instead? The lookup time would be much faster, especially with large number of IPs. Using a map would also simplify the code for removeIP func.
|
What was the issue with CoreDNS? Have we informed the correct teams of a possible issue with CoreDNS? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CoreDNS wasn't playing nice with massive bursts of service name fqdn lookups, this moves to using the ip of the service(s) directly
Please provide a brief description of the changes made in this pull request.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.