fix: skip transient grpc errors in pktmon #1265
Open
+270
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
force-pushed
the
matmerr/pktmontesting
branch
from
8770822 to
de3319d
Compare
matmerr
force-pushed
the
matmerr/pktmontesting
branch
from
de3319d to
d24986e
Compare
MikeZappa87
reviewed
Jan 28, 2025
| // commonly seen with: | ||
| // {"error":"failed to receive pktmon event: rpc error: code = Internal desc = unexpected EOF"} | ||
| // {"error":"failed to receive pktmon event: rpc error: code = Internal desc = received 65576-bytes data exceeding the limit 65535 bytes"} | ||
| // {"error":"failed to receive pktmon event: rpc error: code = Internal desc = grpc: failed to unmarshal the received message: proto: cannot parse invalid wire-format data"} |
There was a problem hiding this comment.
Does the Windows team have work items captured to fix these errors?
timraymond
reviewed
Jan 29, 2025
| return errors.Wrapf(err, "failed to get current working directory for pktmon") | ||
| } | ||
|
|
||
| cmd := pwd + "\\" + "controller-pktmon.exe" |
There was a problem hiding this comment.
Would it be better to locate this with exec.LookPath?
|
|
||
| func (p *WindowsGRPCManager) Stop() error { | ||
| if p.pktmonCmd != nil { | ||
| err := p.pktmonCmd.Process.Kill() |
There was a problem hiding this comment.
This is fire-and-forget. Do we care? If so, we need p.pktmonCmd.Process.Wait() (and probably some context timeout).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are known transient issues that show up running gRPC on windows in hostnetworking, a few of these don't need restart the client/server. The goal here is to accommodate those transient errors while preserving restart behavior for critical errors.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.