fix: Fix retina capture download failing due to empty BLOB_URL #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil <[email protected]>
rbtr
reviewed
Jan 10, 2025
rbtr
approved these changes
Jan 10, 2025
kamilprz
added a commit
to kamilprz/retina
that referenced
this pull request
Jan 16, 2025
…soft#1206) # Description Prior to this PR, exporting a `BLOB_URL` variable and running `retina capture download` would throw an error. This was due to Viper (the config manager package) not picking up the value correctly. This PR adds a change that corrects this behaviour. I also added a little bit of context to the error message to make it more explicit. ## Related Issue microsoft#899 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Current behaviour - valid token, but not recognised  Empty BLOB_URL  Valid BLOB_URL  ## Additional Notes Testing was done on my personal blob storage account. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. Signed-off-by: Kamil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this PR, exporting a
BLOB_URLvariable and runningretina capture downloadwould throw an error. This was due to Viper (the config manager package) not picking up the value correctly. This PR adds a change that corrects this behaviour.I also added a little bit of context to the error message to make it more explicit.
Related Issue
#899
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Current behaviour - valid token, but not recognised
Empty BLOB_URL
Valid BLOB_URL
Additional Notes
Testing was done on my personal blob storage account.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.