Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): Ensure windows agent stability using hubble/legacy helm values #1128

Merged
merged 8 commits into from
Jan 3, 2025
Merged

fix(bug): Ensure windows agent stability using hubble/legacy helm values #1128

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
008eb01
fix(bug): Fix invalid helm value rendering for windows manifest
BeegiiK Dec 16, 2024
82f7b7a
fix(bug): Fix RBAC issue with metrics configuration when operator is …
BeegiiK Dec 16, 2024
4296b29
fix(bug): Disbale telemetry for windows agent in hubble path
BeegiiK Dec 16, 2024
b59b9cd
fix(bug): Run setting kubeconfig path for legacy manifest on windows
BeegiiK Dec 16, 2024
548352e
fix(bug): Update windows legacy powershell command
BeegiiK Dec 16, 2024
f4d1115
Merge branch 'main' into issues/1122
BeegiiK Dec 27, 2024
e8ea7ba
Address PR comments
BeegiiK Jan 3, 2025
659880e
Merge branch 'main' into issues/1122
BeegiiK Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deploy/hubble/manifests/controller/helm/retina/templates/agent/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ data:
enabledPlugin: {{ .Values.enabledPlugin_win }}
metricsInterval: {{ .Values.metricsInterval }}
metricsIntervalDuration: {{ .Values.metricsIntervalDuration }}
enableTelemetry: {{ .Values.enableTelemetry }}
enablePodLevel: {{ .Values.enablePodLevel }}
enableTelemetry: false
BeegiiK marked this conversation as resolved.
Show resolved Hide resolved
enablePodLevel: false
BeegiiK marked this conversation as resolved.
Show resolved Hide resolved
remoteContext: {{ .Values.remoteContext }}
bypassLookupIPOfInterest: {{ .Values.bypassLookupIPOfInterest }}
{{- end}}
Expand Down
8 changes: 7 additions & 1 deletion deploy/legacy/manifests/controller/helm/retina/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,13 @@ spec:
containerPort: {{ .Values.retinaPort }}
workingDir: $env:CONTAINER_SANDBOX_MOUNT_POINT
command:
- controller.exe --config ./retina/config.yaml
- powershell.exe
- -command
{{- if semverCompare ">=1.28" .Capabilities.KubeVersion.GitVersion }}
- $env:CONTAINER_SANDBOX_MOUNT_POINT/controller.exe --config ./retina/config.yaml
{{- else }}
- .\setkubeconfigpath.ps1; ./controller.exe --config ./retina/config.yaml --kubeconfig ./kubeconfig
BeegiiK marked this conversation as resolved.
Show resolved Hide resolved
{{- end }}
env:
- name: POD_NAME
valueFrom:
Expand Down
2 changes: 1 addition & 1 deletion windows/kubeconfigtemplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ contexts:
- name: azure-retina-windows@kubernetes
context:
cluster: kubernetes
namespace: {{ .Values.namespace }}
namespace: kube-system
BeegiiK marked this conversation as resolved.
Show resolved Hide resolved
user: azure-retina-windows
current-context: azure-retina-windows@kubernetes
users:
Expand Down
4 changes: 2 additions & 2 deletions windows/manifests/windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
labels:
app: retina
name: retina-win
namespace: {{ .Values.namespace }}
namespace: kube-system
annotations:
prometheus.io/port: "10093"
prometheus.io/scrape: "true"
Expand Down Expand Up @@ -62,7 +62,7 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: retina-config-win
namespace: {{ .Values.namespace }}
namespace: kube-system
data:
config.yaml: |-
apiServer:
Expand Down
Loading