Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor usages of unsafe #110

Closed
wants to merge 7 commits into from
Closed

fix: Refactor usages of unsafe #110

wants to merge 7 commits into from

Conversation

Troy-Butler
Copy link

Addresses issue #95

@Troy-Butler Troy-Butler requested a review from a team as a code owner March 21, 2024 20:30
@nddq nddq added type/enhancement New feature or request type/fix Fixes something labels Mar 21, 2024
timraymond
timraymond previously approved these changes Mar 22, 2024
@Troy-Butler Troy-Butler requested a review from rbtr March 25, 2024 17:19
@rbtr rbtr added this to the v0.0.2 milestone Mar 25, 2024
@rbtr rbtr requested a review from timraymond March 25, 2024 20:39
Copy link
Contributor

@anubhabMajumdar anubhabMajumdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Testing Done section in description?

@rbtr rbtr modified the milestones: v0.0.2, v0.0.3 Mar 26, 2024
@rbtr rbtr added priority/2 P2 and removed type/enhancement New feature or request labels Mar 28, 2024
@rbtr
Copy link
Collaborator

rbtr commented Mar 29, 2024

@anubhabMajumdar are you willing to take this now that E2E is running?

@anubhabMajumdar
Copy link
Contributor

@anubhabMajumdar are you willing to take this now that E2E is running?

@Troy-Butler Can you update the description with testing done for advanced mode and paste the advanced TCP metrics generated? Either local or remote context would work. This would ensure your code changes are tested. Thanks!

@Troy-Butler
Copy link
Author

@anubhabMajumdar are you willing to take this now that E2E is running?

@Troy-Butler Can you update the description with testing done for advanced mode and paste the advanced TCP metrics generated? Either local or remote context would work. This would ensure your code changes are tested. Thanks!

Please forgive my ignorance, this is my first contribution to this project. What do I need to run to generate the metrics you need?

@anubhabMajumdar
Copy link
Contributor

@anubhabMajumdar are you willing to take this now that E2E is running?

@Troy-Butler Can you update the description with testing done for advanced mode and paste the advanced TCP metrics generated? Either local or remote context would work. This would ensure your code changes are tested. Thanks!

Please forgive my ignorance, this is my first contribution to this project. What do I need to run to generate the metrics you need?

Apologies, I should have included the instructions. Here's how you can get started:

Another way to quickly test a single plugin on your host machine (in your case that would be Packetparser) would be this - https://retina.sh/docs/contributing/#build (look for To build binary of a plugin and test it).

Here's the corresponding main file you need to run - https://github.com/microsoft/retina/blob/main/test/plugin/packetparser/main_linux.go .
You would also need to build and run - https://github.com/microsoft/retina/tree/main/init/retina .

Let me know if you need any help, would be happy to help! Thanks again for your contribution.

@rbtr rbtr modified the milestones: 2024/04/02, 2024/04/09 Apr 3, 2024
@rbtr rbtr changed the title fix: Refactor usages of unsafe (microsoft#95) fix: Refactor usages of unsafe Apr 18, 2024
@Troy-Butler Troy-Butler deleted the refactor-unsafe branch April 22, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/2 P2 type/fix Fixes something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants