-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactor usages of unsafe #110
Conversation
Signed-off-by: Troy-Butler <[email protected]>
This reverts commit 6fd62ba.
Signed-off-by: Troy-Butler <[email protected]>
…na_tb into refactor-unsafe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add Testing Done
section in description?
@anubhabMajumdar are you willing to take this now that E2E is running? |
@Troy-Butler Can you update the description with testing done for |
Please forgive my ignorance, this is my first contribution to this project. What do I need to run to generate the metrics you need? |
Apologies, I should have included the instructions. Here's how you can get started:
Another way to quickly test a single plugin on your host machine (in your case that would be Packetparser) would be this - https://retina.sh/docs/contributing/#build (look for Here's the corresponding main file you need to run - https://github.com/microsoft/retina/blob/main/test/plugin/packetparser/main_linux.go . Let me know if you need any help, would be happy to help! Thanks again for your contribution. |
Addresses issue #95