Skip to content

test: add test to measure rate of growth of metrics #4612

test: add test to measure rate of growth of metrics

test: add test to measure rate of growth of metrics #4612

Triggered via pull request January 13, 2025 17:34
Status Failure
Total duration 5m 41s
Artifacts

golangci-lint.yaml

on: pull_request
Matrix: Lint
Fit to window
Zoom out
Zoom in

Annotations

36 errors and 4 warnings
Lint (windows, arm64): test/e2e/framework/metrics/query-publish.go#L140
Error return value of `file.Write` is not checked (errcheck)
Lint (windows, arm64): test/e2e/framework/metrics/query-publish.go#L141
Error return value of `file.WriteString` is not checked (errcheck)
Lint (windows, arm64): test/e2e/framework/metrics/query-publish.go#L80
commentedOutCode: may want to remove commented-out code (gocritic)
Lint (windows, arm64): test/e2e/framework/metrics/query-publish.go#L90
var-naming: var promApi should be promAPI (revive)
Lint (windows, arm64): test/e2e/growth_metrics_test.go#L20
var-naming: func parameter subscriptionId should be subscriptionID (revive)
Lint (windows, arm64): test/e2e/growth_metrics_test.go#L35
var-naming: var portForwardId should be portForwardID (revive)
Lint (windows, arm64): test/e2e/growth_metrics_test.go#L36
var-naming: var metricsStepId should be metricsStepID (revive)
Lint (windows, arm64): test/e2e/framework/metrics/query-publish.go#L163
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"retinaVersion is required in AdditionalTelemetryProperty\")" (err113)
Lint (windows, arm64)
issues found
Lint (windows, amd64): test/e2e/framework/metrics/query-publish.go#L140
Error return value of `file.Write` is not checked (errcheck)
Lint (windows, amd64): test/e2e/framework/metrics/query-publish.go#L141
Error return value of `file.WriteString` is not checked (errcheck)
Lint (windows, amd64): test/e2e/framework/metrics/query-publish.go#L80
commentedOutCode: may want to remove commented-out code (gocritic)
Lint (windows, amd64): test/e2e/framework/metrics/query-publish.go#L90
var-naming: var promApi should be promAPI (revive)
Lint (windows, amd64): test/e2e/growth_metrics_test.go#L20
var-naming: func parameter subscriptionId should be subscriptionID (revive)
Lint (windows, amd64): test/e2e/growth_metrics_test.go#L35
var-naming: var portForwardId should be portForwardID (revive)
Lint (windows, amd64): test/e2e/growth_metrics_test.go#L36
var-naming: var metricsStepId should be metricsStepID (revive)
Lint (windows, amd64): test/e2e/framework/metrics/query-publish.go#L163
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"retinaVersion is required in AdditionalTelemetryProperty\")" (err113)
Lint (windows, amd64)
issues found
Lint (linux, arm64): test/e2e/framework/metrics/query-publish.go#L140
Error return value of `file.Write` is not checked (errcheck)
Lint (linux, arm64): test/e2e/framework/metrics/query-publish.go#L141
Error return value of `file.WriteString` is not checked (errcheck)
Lint (linux, arm64): test/e2e/framework/metrics/query-publish.go#L80
commentedOutCode: may want to remove commented-out code (gocritic)
Lint (linux, arm64): test/e2e/framework/metrics/query-publish.go#L90
var-naming: var promApi should be promAPI (revive)
Lint (linux, arm64): test/e2e/growth_metrics_test.go#L20
var-naming: func parameter subscriptionId should be subscriptionID (revive)
Lint (linux, arm64): test/e2e/growth_metrics_test.go#L35
var-naming: var portForwardId should be portForwardID (revive)
Lint (linux, arm64): test/e2e/growth_metrics_test.go#L36
var-naming: var metricsStepId should be metricsStepID (revive)
Lint (linux, arm64): test/e2e/framework/metrics/query-publish.go#L163
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"retinaVersion is required in AdditionalTelemetryProperty\")" (err113)
Lint (linux, arm64)
issues found
Lint (linux, amd64): test/e2e/framework/metrics/query-publish.go#L140
Error return value of `file.Write` is not checked (errcheck)
Lint (linux, amd64): test/e2e/framework/metrics/query-publish.go#L141
Error return value of `file.WriteString` is not checked (errcheck)
Lint (linux, amd64): test/e2e/framework/metrics/query-publish.go#L80
commentedOutCode: may want to remove commented-out code (gocritic)
Lint (linux, amd64): test/e2e/framework/metrics/query-publish.go#L90
var-naming: var promApi should be promAPI (revive)
Lint (linux, amd64): test/e2e/growth_metrics_test.go#L20
var-naming: func parameter subscriptionId should be subscriptionID (revive)
Lint (linux, amd64): test/e2e/growth_metrics_test.go#L35
var-naming: var portForwardId should be portForwardID (revive)
Lint (linux, amd64): test/e2e/growth_metrics_test.go#L36
var-naming: var metricsStepId should be metricsStepID (revive)
Lint (linux, amd64): test/e2e/framework/metrics/query-publish.go#L163
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"retinaVersion is required in AdditionalTelemetryProperty\")" (err113)
Lint (linux, amd64)
issues found
Lint (windows, arm64)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint (windows, amd64)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint (linux, arm64)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint (linux, amd64)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636