Fix issue with mixed border widths on Fabric #11561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were checking if the color was variable per side but assuming width wouldn't be. Fixes microsoft#11549
microsoft-github-policy-service
bot
added
Area: Borders and Brushes
Area: Fabric
acoates-ms
approved these changes
May 4, 2023
chrisglein
added a commit
to chrisglein/artificial-chat
that referenced
this pull request
May 5, 2023
chrisglein
added
the
AutoMerge
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Fabric if you had specified a border on one side but not varying colors, it would not apply the border.
Type of Change
Why
Resolves #11549
What
Check not just for non-uniform colors, but also for non-uniform sizes.
Screenshots
Testing
Modified pages in RNTester to cause it to repro (existing examples were either too plain or too fancy - none specifically had the repro of "set a single border other than the left border").
Also patched into an app and validated it there.
Microsoft Reviewers: Open in CodeFlow