-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A mechanism for listening to lifecycle events in RNTA #275
Conversation
dac613f
to
32b6445
Compare
85a87b9
to
469a76a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine in general. I left a few questions because I have no idea how Android works.
android/app/src/main/java/com/microsoft/reacttestapp/TestApp.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only some minor comments.
android/app/src/main/java/com/microsoft/reacttestapp/TestApp.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
97ab55c
to
ecc1828
Compare
🎉 This PR is included in version 0.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR adds a mechanism for listening lifecycle events such as application start, RN init, etc. It does it by looking-up methods in ReactPackage's provided by native modules using reflection.
The issue #145 is somewhat relevant, but doesn't address the exact problem.
Platforms affected
Test plan
To test this change, you will need to link a native module that has a ReactPackage with one (or all) of the following methods: