Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deprecated and Unimplemented attributes #785

Closed
wants to merge 9 commits into from
+593 −52
Closed

Add Deprecated and Unimplemented attributes #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d13455c
WIP: add Deprecated, Unimplemented attrs
swernli Oct 10, 2023
b184e32
Allow empty deprecation attr
swernli Oct 12, 2023
10076df
Update language service
swernli Oct 12, 2023
6b177a3
Avoid ambiguous error on deprecated/unimplemented
swernli Oct 16, 2023
51c4514
Add tests
swernli Oct 17, 2023
f2b36ba
Rework item info tracking as item status
swernli Oct 18, 2023
fdf2599
Move error reporting up in stack
swernli Oct 18, 2023
8fb97f7
Disallow unimplemented within unit
swernli Oct 18, 2023
fad70ae
Merge remote-tracking branch 'origin/main' into swernli/impl-attrs
swernli Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/qsc_frontend/src/compile/preprocess.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use qsc_ast::{
ast::{Attr, ExprKind, ItemKind, Namespace, Stmt, StmtKind},
mut_visit::MutVisitor,
};
use qsc_hir::hir;
use std::rc::Rc;

use super::TargetProfile;
Expand Down Expand Up @@ -119,7 +120,7 @@ impl MutVisitor for Conditional {

fn matches_target(attrs: &[Box<Attr>], target: TargetProfile) -> bool {
attrs.iter().all(|attr| {
if attr.name.name.as_ref() == "Config" {
if hir::Attr::from_str(attr.name.name.as_ref()) == Ok(hir::Attr::Config) {
if let ExprKind::Paren(inner) = attr.arg.kind.as_ref() {
match inner.kind.as_ref() {
ExprKind::Path(path) => {
Expand Down
Loading