Annotate conditional compilation for fixed_point so it compiles in all profiles #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minestarks
approved these changes
Feb 4, 2025
swernli
reviewed
Feb 6, 2025
| @@ -25,6 +27,8 @@ operation AssertAllZeroFxP(fp : FixedPoint) : Unit { | |||
| /// Array of quantum fixed-point numbers that will be checked for | |||
| /// compatibility (using assertions). | |||
| function AssertFormatsAreIdenticalFxP(fixedPoints : FixedPoint[]) : Unit { | |||
| import Std.Diagnostics.Fact; | |||
There was a problem hiding this comment.
This one is imported globally, so the local one isn't needed anymore.
Suggested change
| import Std.Diagnostics.Fact; |
swernli
reviewed
Feb 6, 2025
Comment on lines
+55
to
+56
|
|
||
|
|
There was a problem hiding this comment.
these blank lines might be leftover from an earlier version.
Suggested change
swernli
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2143