LS: Hide errors from github sources only when they're not associated with a real project #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minestarks
requested review from
billti,
idavis and
ScottCarda-MS
as code owners
swernli
approved these changes
Feb 6, 2025
ScottCarda-MS
approved these changes
Feb 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to #1787 while staying true to the intention of that change.
We want to hide errors from GitHub sources that are open in the editor, but aren't associated with a project. They're essentially orphans. For example, you may have closed the original project that referenced those GitHub sources, but left the GitHub source open in the editor.
But we want to show errors from GitHub sources if they're part of a normal project. Errors from dependencies are helpful.