Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dependency graph for qsc and qsc_qasm3 #2134

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented Jan 28, 2025

This change reorganizes the deps for qsc, qsc_qasm3, and the pip package. The qsc crate will now depend on qsc_qasm3 and reexport the appropriate API surface. The pip package now consumes that exported API from qsc.

@idavis idavis self-assigned this Jan 28, 2025
Copy link
Member

@minestarks minestarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but what was the motivation for this?

@idavis
Copy link
Collaborator Author

idavis commented Jan 28, 2025

Enabling future work for consuming the crates more generally.

@idavis idavis added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 3b32013 Jan 31, 2025
18 checks passed
@idavis idavis deleted the iadavis/dep-reorg branch January 31, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants