Add lint for double (in)equality #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpuente-MS
requested review from
idavis,
minestarks and
swernli
as code owners
orpuente-MS
requested review from
DmitryVasilevsky,
sezna and
tcNickolas
as code owners
swernli
approved these changes
Jan 22, 2025
sezna
reviewed
Jan 23, 2025
sezna
approved these changes
Jan 23, 2025
Co-authored-by: Alex Hansen <[email protected]>
idavis
pushed a commit
that referenced
this pull request
Feb 2, 2025
This PR adds a lint for double equality and inequality. It also updates the DF Chemistry sample to perform a correct `NAN` check. --------- Co-authored-by: Alex Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lint for double equality and inequality.
It also updates the DF Chemistry sample to perform a correct
NANcheck.