Added DoubleAsStringWithPrecision function - Single Qubit Gate #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devikamehra
requested review from
billti,
cesarzc,
DmitryVasilevsky,
sezna,
swernli and
tcNickolas
as code owners
|
Similar to your other PR. I got confused by the current title. It might be a good idea to :
|
devikamehra
changed the title
tcNickolas
suggested changes
Aug 26, 2024
There was a problem hiding this comment.
Please make sure to use space after commas to make the code more readable.
The numbers we're using here are not usually less than 0.1, so I don't think they warrant such a high precision, 2-3 digits should be plenty - the main goal of this change is to shorten the error messages
Thank you!
tcNickolas
approved these changes
Aug 27, 2024
katas/content/single_qubit_gates/amplitude_change/Verification.qs
Outdated
Show resolved
Hide resolved
cesarzc
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DoubleAsStringWithPrecision function to Single Qubit Gate Kata
This is to address the issue #1788