-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate nonlocal games 1596 task1 - quantum #1745
Migrate nonlocal games 1596 task1 - quantum #1745
Conversation
|
katas/content/nonlocal_games/chsh_quantum_bob_strategy/solution.md
Outdated
Show resolved
Hide resolved
…ggridin/qsharp into MigrateNonlocalGames-1596-task1
Yes, that's expected. The katas exercises run Unrestricted and do not need to be compatible with QIR Base profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay reviewing this PR, I had a very busy week :-(
Here are the comments for most of the changes, except for the ones in the root index.md - I'll review that file a bit later today.
Thank you!
katas/content/nonlocal_games/chsh_quantum_alice_strategy/Solution.qs
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_alice_strategy/Solution.qs
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_bob_strategy/Solution.qs
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_alice_strategy/index.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_alice_strategy/solution.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_alice_strategy/Verification.qs
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_bob_strategy/index.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_bob_strategy/solution.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reading through the index.md, posting the rest of the comments.
Additionally, could you please edit the PR description to move out everything starting with "other PRs will follow"? These details are good to include for the reviewer while the PR is in progress, but our merge system is set up in a way that includes the whole PR description in the commit message, and they're not necessary there, just making the commit info look bulky. For future PRs, these details can be made into the first comment on the PR rather than a part of the description.
Thank you!!
Additional details of this PR:
Testing done:
|
@tcNickolas In the current PR, I've updated PR description according your suggestion and moved the details to one of the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! And the updated demo is much more illustrative of the differences between classical and quantum strategies!
I left a few minor comments, but I shouldn't need to take another look. Just need a second reviewer's signoff.
Thank you!
katas/content/nonlocal_games/chsh_quantum_alice_strategy/Solution.qs
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_alice_strategy/solution.md
Outdated
Show resolved
Hide resolved
katas/content/nonlocal_games/chsh_quantum_bob_strategy/index.md
Outdated
Show resolved
Hide resolved
…ion.qs Co-authored-by: Mariia Mykhailova <[email protected]>
…ion.md Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
The link to the issue: #1596
This pull request is covering