-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip commenting memory/perf benches on draft PRs #1694
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for ffac5b7Click to view benchmark
|
swernli
reviewed
Jul 2, 2024
It looks like the tests for the npm package got stuck for the last two hours on macos-14... @billti have you seen anything like this before? |
Benchmark for d0e85f3Click to view benchmark
|
swernli
approved these changes
Jul 2, 2024
idavis
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help reduce some of the comment noise until we have time to customize that action some more.
I tested that this works on this PR -- the benches are not run when the PR is a draft.
I had to pull the two relevant jobs out into a different workflow file, because the triggers are different. For the reporting benches stage (the memory and perf comments that show up on PRs), they'll only run if the PR is in a draft. But, and this is the different part that required them being in a separate file, they also need to trigger when a PR is marked "ready for review".