Packages for Q# #1693
Closed
Packages for Q# #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86e99b9.
…tarks/package-resolution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -49,12 +49,16 @@ | |||
|
|
|||
| impl CompilationContext { | |||
| fn new(source: &str) -> Self { | |||
| let mut store = qsc::PackageStore::new(qsc::compile::core()); | |||
| // TODO(alex) ask cesarzc if std is wanted here | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
There was a problem hiding this comment.
@cesarzc should these tests include the stdlib or no?
|
Change in memory usage detected by benchmark. Memory Report for 3b462ee
|
Benchmark for 3b462eeClick to view benchmark
|
|
Change in memory usage detected by benchmark. Memory Report for 6437607
|
Benchmark for 6437607Click to view benchmark
|
sezna
commented
Jul 2, 2024
sezna
commented
Jul 2, 2024
sezna
commented
Jul 2, 2024
sezna
commented
Jul 2, 2024
Merged
|
Superseded by #1698 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
This PR: 1. Refactors the compiler API such that the caller passes in a constructed package store, allowing for dependencies to be pre-compiled and inserted before compiling user code 2. Introduces the `BuildableProgram` abstraction, which encapsulates the notion of "some user code that is ready to compile, along with a package store that has all of its dependencies compiled" 3. As a drive-by fix, fixes circuits for internal operations 4. Removes the notion of `Visibility` from the AST, since visibility is calculated via exports now. `internal` is still parsed without error for backwards compatibility, but is a no-op because `internal` is the default now. 5. Enforces visibility in the HIR, where items must be `Visibility::Public` to show up across packages as a `GlobalItem` 6. Adds export statements to the standard library to preserve the existing API with the new internal-by-default semantics 7. Inserts all packages into the user code's namespace tree with the prefix defined as the package alias in the `qsharp.json` closes #883 The Q# formatting CI stage will fail until #1692 goes in This PR supersedes #1693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP branch, putting it up for code review meetings
This PR:
BuildableProgramabstraction, which encapsulates the notion of "some user code that is ready to compile, along with a package store that has all of its dependencies compiled"Visibilityfrom the AST, since visibility is calculated via exports now.internalis still parsed without error for backwards compatibility, but is a no-op becauseinternalis the default now.Visibility::Publicto show up across packages as aGlobalItemqsharp.jsoncloses #883
The Q# formatting CI stage will fail until #1692 goes in