New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FollowUp] Quick fix for `NeedlessOperation` lint #1593

Open

Manvi-Agrawal opened this issue May 30, 2024 · 0 comments

Labels

Contributor

Manvi-Agrawal commented May 30, 2024

#1579 (comment)

Manvi-Agrawal added enhancement needs triage labels

Manvi-Agrawal mentioned this issue

[Unitary-Hack] Lint rule: Use functions #1579

Merged

github-merge-queue bot pushed a commit that referenced this issue


          [Unitary-Hack] Lint rule: Use functions (#1579)

2454f09

Fixes #1471.

### Future TODO
- #1585
- #1593


![image](https://github.com/microsoft/qsharp/assets/40084144/3c512530-ac54-4f9b-85f5-b6327917b7b2)

![image](https://github.com/microsoft/qsharp/assets/40084144/9eeec703-c92e-4906-aecf-91ace0b594d2)


Based on
https://github.com/microsoft/qsharp/blob/main/compiler/qsc_passes/src/callable_limits.rs

### Note to reviewers
Main changes are in `qsc_linter` folder. Changes in other tests are due
to this lint rule complaining about NeedlessOperation, so I converted to
function and it changes span accordingly.

---------

Co-authored-by: orpuente-MS <[email protected]>
Co-authored-by: Mine Starks <[email protected]>

sezna removed the needs triage label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment